feat(api): repair corrupted blobs when pushed again #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
force-pushed
the
corrupted_blobs
branch
from
bb0312c to
231ab3f
Compare
andaaron
previously approved these changes
Oct 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #1927 +/- ##
==========================================
+ Coverage 91.86% 91.88% +0.01%
==========================================
Files 155 155
Lines 26702 26785 +83
==========================================
+ Hits 24531 24611 +80
- Misses 1607 1609 +2
- Partials 564 565 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eusebiu-constantin-petu-dbk
force-pushed
the
corrupted_blobs
branch
2 times, most recently
from
e11b3e4 to
1ab971b
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
corrupted_blobs
branch
3 times, most recently
from
86304bf to
b3ad585
Compare
andaaron
reviewed
Oct 18, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
corrupted_blobs
branch
2 times, most recently
from
19de1d7 to
d2b59fa
Compare
|
needed to increase a bit the delays on minio because it failed multiple times. The added overhead of checking manifests is big enough to interfere, but small enough to not impact the Minimum performance regression check. When I used the digest to calculate a blob's digest, and validate, the Minimum performance regression check failed. |
CheckBlob() returns ErrBlobNotFound on corrupted blobs closes project-zot#1922 Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
corrupted_blobs
branch
from
d2b59fa to
575fdb8
Compare
andaaron
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckBlob() returns ErrBlobNotFound on corrupted blobs
closes #1922
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.